fix: PCV validation for previous fiscal year (backport #40572) #40583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit a1d108c)
mergify
bot
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
|
🎉 This PR is included in version 14.66.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to replicate bug
The validation checks if the previous fiscal year exists, if yes check for any GL entries created for the fiscal year, if no GL entries are created, allow submitting the PCV. If it does find GL entries it checks for a PCV for that year and considers it unclosed if no such voucher exists. However, if a cancelled GL entry exists in any of the past years then the validation still fails.
Fix
Do not consider cancelled GL entries for the validation.
This is an automatic backport of pull request #40572 done by [Mergify](https://mergify.com).