Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect cost_center in ar/ap #43174

Closed
wants to merge 1 commit into from

Conversation

ljain112
Copy link
Contributor

If there is a journal entry with the same accounts but a different cost centre Accounts Receivable shows an incorrect cost center.

Support Issue: https://support.frappe.io/app/hd-ticket/21671

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 11, 2024
@ljain112 ljain112 marked this pull request as draft September 11, 2024 13:30
@ruthra-kumar ruthra-kumar self-assigned this Sep 17, 2024
@ruthra-kumar ruthra-kumar removed the request for review from deepeshgarg007 September 17, 2024 05:09
@ruthra-kumar
Copy link
Member

@ljain112
Let's not add cost_center to the key variable. Accounting Dimension is not a mandatory field to link Invoices with Payments.

Copy link

stale bot commented Oct 5, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Oct 5, 2024
@stale stale bot closed this Nov 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
inactive needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants