Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make free qty round on large transaction qty #44266

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

venkat102
Copy link
Contributor

Issue:
Promotional Scheme free qty roundoff not working properly on larger transaction qty
ref: 25810

Promotional Scheme:
Screenshot from 2024-11-21 18-46-03

Before:
image

After:
image

Backport needed: v14 & v15

@ruthra-kumar ruthra-kumar self-assigned this Nov 22, 2024
@ruthra-kumar ruthra-kumar merged commit 367f561 into frappe:develop Nov 22, 2024
14 checks passed
ruthra-kumar added a commit that referenced this pull request Nov 22, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…-44266

fix: make free qty round on large transaction qty (backport #44266)
ruthra-kumar added a commit that referenced this pull request Nov 22, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…-44266

fix: make free qty round on large transaction qty (backport #44266)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants