Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: stock closing balance -> stock closing entry #44489

Merged

Conversation

rohitwaghchaure
Copy link
Collaborator

@rohitwaghchaure rohitwaghchaure commented Dec 3, 2024

New Doctype "Stock Closing Entry"

image

The purpose of the stock closing entry is to generate the stock closing balance, which includes the consolidated stock quantity and consolidated stock value for the selected period. This will help to improve the performance of stock reports such as Stock Balance and Batch-Wise Balance History.

How it works

On submission of the stock closing entry, the system generates the stock closing balances based on the following combinations

  • item, warehouse
  • item, warehouse, batch no
  • item, warehouse, dimension

If there are two inventory dimensions such as Rack and Bin then

  • item, warehouse, rack 1
  • item, warehouse, bin 1
  • item, warehouse, rack1, bin 1
image

While generating the stock balance report, system reads the opening stock from the Stock Closing Balance instead of stock ledger entries

docs https://docs.frappe.io/erpnext/stock-closing-entry

@rohitwaghchaure rohitwaghchaure marked this pull request as draft December 3, 2024 13:06
@rohitwaghchaure rohitwaghchaure force-pushed the revamp-stock-closing-balance branch 16 times, most recently from 4a76720 to 24b8384 Compare December 11, 2024 05:17
@rohitwaghchaure rohitwaghchaure force-pushed the revamp-stock-closing-balance branch from 24b8384 to e616ef0 Compare December 26, 2024 06:30
@rohitwaghchaure rohitwaghchaure changed the title refactor: stock closing balance refactor: stock closing balance -> stock closing entry Dec 26, 2024
@rohitwaghchaure rohitwaghchaure force-pushed the revamp-stock-closing-balance branch from e616ef0 to be5c3d3 Compare December 26, 2024 08:56
@rohitwaghchaure rohitwaghchaure marked this pull request as ready for review December 26, 2024 17:08
@rohitwaghchaure rohitwaghchaure merged commit c9088f4 into frappe:develop Dec 26, 2024
19 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant