Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: required by date in the reorder material request (backport #44497) (backport #44508) #44535

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 5, 2024

Issue

The lead time days in the item master are not considered when automatically calculating the 'Required By' date in the material request created based on the reorder level.

Lead time days = 25 (in the item master)
Today's date = 04-12-2024
Expected Required By Date = 29-12-2024
Actual Required By Date = 04-12-2024 (Wrong)

Screenshot 2024-12-04 at 12 27 35 PM

After Fix

Screenshot 2024-12-04 at 12 25 42 PM
This is an automatic backport of pull request #44497 done by [Mergify](https://mergify.com).
This is an automatic backport of pull request #44508 done by [Mergify](https://mergify.com).

… (#44508)

* fix: required by date in the reorder material request (#44497)

(cherry picked from commit 4001166)

# Conflicts:
#	erpnext/stock/doctype/stock_entry/test_stock_entry.py

* chore: fix conflicts

---------

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
(cherry picked from commit 15e3663)
@mergify mergify bot requested a review from rohitwaghchaure as a code owner December 5, 2024 07:25
@github-actions github-actions bot added the stock label Dec 5, 2024
@rohitwaghchaure rohitwaghchaure merged commit 86ff154 into version-14 Dec 5, 2024
11 checks passed
@rohitwaghchaure rohitwaghchaure deleted the mergify/bp/version-14/pr-44508 branch December 5, 2024 08:17
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.78.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants