Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only show advance payment entries where "book_advance_payments_in_separate_party_account" is true #44545

Merged
merged 2 commits into from
Dec 9, 2024
Merged

fix: only show advance payment entries where "book_advance_payments_in_separate_party_account" is true #44545

merged 2 commits into from
Dec 9, 2024

Conversation

ljain112
Copy link
Contributor

@ljain112 ljain112 commented Dec 5, 2024 •
edited
Loading

Issue: Incorrect reconciliation is happening when payment entry is made with the advance account but book_advance_payments_in_separate_party_account was disabled in the Account Settings.

Steps to Replicate:

  • Create an Advance Receivable Account.
  • Create a Sales Invoice
  • Disable "book_advance_payments_in_separate_party_account" in company.
  • Create a Payment Entry in the Advance Receivable Account.
  • Enable "book_advance_payments_in_separate_party_account".
  • Reconciliation of the payment against the Invoice
  • Reconciliation will be successful but outstanding will not be adjusted because the Party Account is different and payment entry is not advance payment entry.

Frappe Support Issue: https://support.frappe.io/app/hd-ticket/24578

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Dec 5, 2024
@ljain112 ljain112 marked this pull request as ready for review December 6, 2024 08:14
@ruthra-kumar ruthra-kumar self-assigned this Dec 9, 2024
@ruthra-kumar ruthra-kumar merged commit 6e02e29 into frappe:develop Dec 9, 2024
13 checks passed
@mergify mergify bot mentioned this pull request Dec 9, 2024
Closed
@ruthra-kumar ruthra-kumar mentioned this pull request Dec 9, 2024
Merged
ruthra-kumar added a commit that referenced this pull request Dec 10, 2024
@ruthra-kumar
Merge pull request #44622 from ruthra-kumar/backport_v15_pr_44545
eae5996 
fix: only show advance payment entries where "book_advance_payments_in_separate_party_account" is true (backport #44545)
@Sanket322 Sanket322 mentioned this pull request Dec 11, 2024
Merged
@mergify mergify bot mentioned this pull request Dec 12, 2024
Closed
@ljain112 ljain112 mentioned this pull request Dec 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar ruthra-kumar is a code owner

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees

@ruthra-kumar ruthra-kumar

Labels
accounts backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljain112 @ruthra-kumar