Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: not able to make sales return entry #44605

Merged
merged 1 commit into from
Dec 9, 2024
Merged

fix: not able to make sales return entry #44605

merged 1 commit into from
Dec 9, 2024

Conversation

rohitwaghchaure
Copy link
Collaborator

Issue

  File "apps/erpnext/erpnext/stock/doctype/serial_and_batch_bundle/serial_and_batch_bundle.py", line 210, in set_incoming_rate
    self.set_valuation_rate_for_return_entry(return_aginst, save)
  File "apps/erpnext/erpnext/stock/doctype/serial_and_batch_bundle/serial_and_batch_bundle.py", line 230, in set_valuation_rate_for_return_entry
    row.db_set(
  File "apps/frappe/frappe/model/document.py", line 1230, in db_set
    frappe.db.set_value(
  File "apps/frappe/frappe/database/database.py", line 989, in set_value
    query.run(debug=debug)
  File "apps/frappe/frappe/query_builder/utils.py", line 87, in execute_query
    result = frappe.db.sql(query, params, *args, **kwargs)  # nosemgrep
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/database/database.py", line 229, in sql
    self._cursor.execute(query, values)
  File "env/lib/python3.11/site-packages/pymysql/cursors.py", line 153, in execute
    result = self._query(query)
             ^^^^^^^^^^^^^^^^^^
  File "env/lib/python3.11/site-packages/pymysql/cursors.py", line 322, in _query
    conn.query(q)
  File "env/lib/python3.11/site-packages/pymysql/connections.py", line 563, in query
    self._affected_rows = self._read_query_result(unbuffered=unbuffered)
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "env/lib/python3.11/site-packages/pymysql/connections.py", line 825, in _read_query_result
    result.read()
  File "env/lib/python3.11/site-packages/pymysql/connections.py", line 1199, in read
    first_packet = self.connection._read_packet()
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "env/lib/python3.11/site-packages/pymysql/connections.py", line 775, in _read_packet
    packet.raise_for_error()
  File "env/lib/python3.11/site-packages/pymysql/protocol.py", line 219, in raise_for_error
    err.raise_mysql_exception(self._data)
  File "env/lib/python3.11/site-packages/pymysql/err.py", line 150, in raise_mysql_exception
    raise errorclass(errno, errval)
pymysql.err.IntegrityError: (1048, "Column 'incoming_rate' cannot be null")

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Dec 9, 2024
@rohitwaghchaure rohitwaghchaure merged commit 314c7b8 into frappe:develop Dec 9, 2024
14 checks passed
mergify bot pushed a commit that referenced this pull request Dec 9, 2024
@rohitwaghchaure @mergify
fix: not able to make sales return entry (#44605)
4abdbce 
(cherry picked from commit 314c7b8)
rohitwaghchaure added a commit that referenced this pull request Dec 9, 2024
@mergify @rohitwaghchaure
fix: not able to make sales return entry (backport #44605) (#44613)
04b07a9 
fix: not able to make sales return entry (#44605)

(cherry picked from commit 314c7b8)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Dec 12, 2024
@frappe-bot
chore(release): Bumped to Version 15.45.5
6e01a9b 
## [15.45.5](v15.45.4...v15.45.5) (2024-12-12)

### Bug Fixes

* 'Use Multi-Level BOM' checkbox default value (backport [#44618](#44618)) ([#44620](#44620)) ([5cd3994](5cd3994))
* add docstatus for translation ([47e1ed1](47e1ed1))
* add label strings for translation in pos_controller.js ([ffdd7cf](ffdd7cf))
* add labels for translation in production_analytics.py ([7a6cb0f](7a6cb0f))
* add labels for translation in purchase_order_analysis.py ([f06827c](f06827c))
* add labels for translation in quality_inspection_summary.py ([dd3a747](dd3a747))
* add labels for translation in sales_order_analysis.py ([6980d1e](6980d1e))
* add labels for translation in sales_order.js ([283043e](283043e))
* add string for translation in delayed_tasks_summary.py ([43fc8bf](43fc8bf))
* add strings for translation in pos_item_cart.js ([71d8dfb](71d8dfb))
* add strings for translation in timesheet.js ([#44496](#44496)) ([106671a](106671a))
* add strings for translation payment_terms_status_for_sales_order.py ([773e03f](773e03f))
* add title for translation in  asset.js ([843ff18](843ff18))
* **Bank Transaction:** error in party matching should not block submitting (backport [#44416](#44416)) ([#44574](#44574)) ([31c2b81](31c2b81))
* BOM for variant items (backport [#44580](#44580)) ([#44584](#44584)) ([0b26827](0b26827))
* BOM has not attr required items (backport [#44598](#44598)) ([#44600](#44600)) ([608eaaa](608eaaa))
* BOM name issue (backport [#44575](#44575)) ([#44579](#44579)) ([03ae9e2](03ae9e2))
* BOM name issue (backport [#44586](#44586)) ([#44589](#44589)) ([a5cc307](a5cc307))
* consider zero valuation rate for serial nos (backport [#44532](#44532)) ([#44534](#44534)) ([3771c6e](3771c6e))
* correct color for draft in list view ([cce1cc6](cce1cc6))
* currency symbol in SCO and SCR (backport [#44577](#44577)) ([#44594](#44594)) ([2a17ecd](2a17ecd))
* description overwrite on qty change (backport [#44606](#44606)) ([#44609](#44609)) ([243bf54](243bf54))
* do not allow to inward same serial nos multiple times (backport [#44617](#44617)) ([#44619](#44619)) ([bdb60a5](bdb60a5))
* duplicate required items in the CSV (backport [#44498](#44498)) ([#44507](#44507)) ([539c5b7](539c5b7))
* incorrect stock UOM for BOM raw materials (backport [#44528](#44528)) ([#44531](#44531)) ([f4aa4c9](f4aa4c9))
* inv dimensions fields not creating for standard doctype (backport [#44504](#44504)) ([#44515](#44515)) ([8733eda](8733eda))
* make projected qty editable after submit (backport [#44670](#44670)) ([#44671](#44671)) ([bd9c84d](bd9c84d))
* not able to make PO for returned qty from material request (backport [#44540](#44540)) ([#44547](#44547)) ([5ef063c](5ef063c))
* not able to make sales return entry (backport [#44605](#44605)) ([#44613](#44613)) ([04b07a9](04b07a9))
* precision check for salvage value ([ef5a564](ef5a564))
* prevent set_payment_schedule on return documents ([2560beb](2560beb))
* required by date in the reorder material request (backport [#44497](#44497)) ([#44509](#44509)) ([07df87a](07df87a))
* restrict advance payment entries with flag ([98bd5f2](98bd5f2))
* strings for translation in pos_past_order_summary.js ([ceec5fd](ceec5fd))
* update free item qty while adding same item in seperate row ([f88dc26](f88dc26))
* update qty in SABB if qty changed in stock reco (backport [#44542](#44542)) ([#44546](#44546)) ([99a3271](99a3271))
* validate returned serial nos and batches (backport [#44669](#44669)) ([#44674](#44674)) ([33273fa](33273fa))
* valuation rate for batch in stock reconciliation  (backport [#44657](#44657)) ([#44664](#44664)) ([2466e4c](2466e4c))
* variant qty while making work order from BOM (backport [#44548](#44548)) ([#44551](#44551)) ([63b1df3](63b1df3))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rohitwaghchaure