fix: better indicator base amount for Tax Witholding in Journal Entry (backport #44660) #44734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit 56a0a0d)
mergify
bot
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
|
|
ruthra-kumar
force-pushed
the
mergify/bp/version-14-hotfix/pr-44660
branch
from
3584dc5 to
fa358ac
Compare
- pin ubuntu-22.04
ruthra-kumar
force-pushed
the
mergify/bp/version-14-hotfix/pr-44660
branch
from
fa358ac to
c86174d
Compare
|
🎉 This PR is included in version 14.78.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Ticket: https://support.frappe.io/helpdesk/tickets/26923
Use case
Over deduction of TDS from Journal Entry for an expense booked.
Issue
Excess amount reported forms part of income of supplier if reported as is.
Implementation
Base amount for TDS is lower of total JV value or reverse calculation (from tax rate and tax amount being deducted)
This is to based on the assumption that supplier is deducting TDS manually while staying compliant and there is no under deduction.
backport to version-14 and version-15 is expected
This is an automatic backport of pull request #44660 done by Mergify.