Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create subcontracted PO from Material Request #44745

Merged
merged 4 commits into from
Dec 23, 2024
Merged

feat: Create subcontracted PO from Material Request #44745

merged 4 commits into from
Dec 23, 2024

Conversation

mihir-kandoi
Copy link
Contributor

@mihir-kandoi mihir-kandoi commented Dec 17, 2024 •
edited
Loading

Added feature to create a Subcontracting Purchase Order from Material Request. Reference issue ID #41297

  1. New Purpose field option "Subcontracting" added to Material Request doctype
  2. When a Subcontracting Material Request is submitted, user will then have an option to create a Subcontracted Purchase Order from the Create button on that Material Request
  3. If a Subcontracting BOM is present for the item in the Material Request, its service item will be fetched and added automatically to that item in the newly created PO

https://docs.frappe.io/erpnext/user/manual/en/material-request

@github-actions github-actions bot added buying needs-tests This PR needs automated unit-tests. labels Dec 17, 2024
@rohitwaghchaure rohitwaghchaure marked this pull request as ready for review December 23, 2024 07:41
@rohitwaghchaure rohitwaghchaure merged commit b769901 into develop Dec 23, 2024
18 checks passed
@rohitwaghchaure rohitwaghchaure deleted the new_mr_sc_feat_2 branch December 23, 2024 07:41
Karuppasamy923 pushed a commit to aerele/erpnext that referenced this pull request Dec 24, 2024
@mihir-kandoi @Karuppasamy923
feat: Create subcontracted PO from Material Request (frappe#44745)
4c66725 
* feat: Create subcontracted PO from Material Request

* fix: Made minor changes in logic to pass all test cases

* refactor: Made changes suggested by mentor and simplified logic

* test: Made changes to tests
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohitwaghchaure rohitwaghchaure rohitwaghchaure approved these changes

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar ruthra-kumar is a code owner

Assignees
No one assigned
Labels
buying needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mihir-kandoi @rohitwaghchaure