Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: closing stock balance permissions (backport #44791) #44792

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 19, 2024

Submit button not showing for the closing stock balance


This is an automatic backport of pull request #44791 done by Mergify.

(cherry picked from commit 3662a6a)

# Conflicts:
#	erpnext/stock/doctype/closing_stock_balance/closing_stock_balance.json
@mergify mergify bot requested a review from rohitwaghchaure as a code owner December 19, 2024 09:31
@mergify mergify bot added the conflicts label Dec 19, 2024
Copy link
Contributor Author

mergify bot commented Dec 19, 2024

Cherry-pick of 3662a6a has failed:

On branch mergify/bp/version-14-hotfix/pr-44791
Your branch is up to date with 'origin/version-14-hotfix'.

You are currently cherry-picking commit 3662a6a41d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   erpnext/stock/doctype/closing_stock_balance/closing_stock_balance.json

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@rohitwaghchaure rohitwaghchaure merged commit 4cb27b9 into version-14-hotfix Dec 23, 2024
10 checks passed
@rohitwaghchaure rohitwaghchaure deleted the mergify/bp/version-14-hotfix/pr-44791 branch December 23, 2024 05:24
frappe-pr-bot pushed a commit that referenced this pull request Dec 25, 2024
## [14.78.5](v14.78.4...v14.78.5) (2024-12-25)

### Bug Fixes

* 'str' object has no attribute 'get_sql' ([510e3ce](510e3ce))
* added docs.frappe.io in documentation_url ([#44776](#44776)) ([82a3fd1](82a3fd1))
* buying rate for service item in gross profit report ([7fa3a78](7fa3a78))
* closing stock balance permissions (backport [#44791](#44791)) ([#44792](#44792)) ([4cb27b9](4cb27b9))
* correct tds rate with lower deduction certificate ([d55fe7d](d55fe7d))
* do not set cost_center update_voucher_balance as it is set in init_voucher_balance ([97d5d18](97d5d18))
* fetch tax withholding category from the voucher ([1093c22](1093c22))
* permissions for marking Quotation as lost ([0179358](0179358))
* Remove typo ([422ada2](422ada2))
* show profit and loss after period closing ([1a089da](1a089da))
* slow posting datetime update (backport [#44799](#44799)) ([#44804](#44804)) ([d2ede71](d2ede71))
* update correct cost center in Accounts Receivable Report ([197b13e](197b13e))
* use utility method to generate url ([d042330](d042330))
* **ux:** purchase invoice link in error message ([#44797](#44797)) ([c9d43f4](c9d43f4))
* Warehouse wise Stock Value chart roles (backport [#44865](#44865)) ([#44866](#44866)) ([177ca6f](177ca6f))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.78.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants