New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct tds rate with lower deduction certificate #44794

Open

ljain112 wants to merge 1 commit into frappe:develop from ljain112:fix-ldc

Contributor

ljain112 commented Dec 19, 2024

Issue:
The tax withholding rate is incorrect if tax withholding from_date doesn't match with lower deduction certificate period.
Steps to replicate:

Create a tax withholding category with period 1-10-2024 to 31-3-2025.
Create a Supplier with a tax withholding category.
Create a Lower Deduction Certification for the supplier,valid from 1-4-2024 and valid up to 31-3-2025.
Even though LDC is valid and within the period, it will not be applied due to incorrect date filters.

Solution:
Validating LDC based on inv date.

Frappe Support Issue: https://support.frappe.io/app/hd-ticket/27014

backport version-15-hotfix
backport version-14-hotfix

ljain112 requested a review from ruthra-kumar as a code owner

December 19, 2024 10:51

github-actions bot added the needs-tests label


          fix: correct tds rate with lower deduction certificate

cb9c12d

ljain112 force-pushed the fix-ldc branch from 353017d to cb9c12d Compare

December 19, 2024 10:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels