Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attribute order in create multiple variants dialog #44800

Merged
merged 3 commits into from
Dec 27, 2024

Conversation

ShreyasTheNewbie
Copy link
Contributor

In Item , Create > Multiple Variants dialog displays Attributes in Different Order each time

Before.mp4

Replaced this with frm.doc.attributes.map(idx => idx.attribute)

After.mp4

This pull request includes a change to the erpnext/stock/doctype/item/item.js file. The modification improves the way attribute keys are handled when creating fields from attribute values.

  • erpnext/stock/doctype/item/item.js: Changed the method of iterating over attribute keys by using frm.doc.attributes.map(idx => idx.attribute) instead of Object.keys(attr_dict).

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Fixed attribute order in create multiple variant dialog.
@ShreyasTheNewbie ShreyasTheNewbie changed the title Fix : Attribute order in Create Multiple Variants Dialog fix: Attribute order in Create Multiple Variants Dialog Dec 19, 2024
@ShreyasTheNewbie ShreyasTheNewbie changed the title fix: Attribute order in Create Multiple Variants Dialog fix: attribute order in create multiple variants dialog Dec 19, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Fixed attribute order in create multiple variant dialog.
@ruthra-kumar ruthra-kumar self-assigned this Dec 23, 2024
@ruthra-kumar ruthra-kumar merged commit 751a0a9 into frappe:develop Dec 27, 2024
10 of 11 checks passed
@ruthra-kumar ruthra-kumar self-requested a review December 27, 2024 05:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants