fix: clear payment schedule in purchase invoice for is_paid #44892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanket322
requested review from
ruthra-kumar and
rohitwaghchaure
as code owners
github-actions
bot
added
accounts
needs-tests
validate_advance_entries() has a heavy IO bound operation. Early return on unwanted cases is always better.
ruthra-kumar
added
backport version-14-hotfix
|
validate_advance_entries() has a heavy IO bound operation. So, early return on unwanted cases is always better. |
This was referenced Dec 27, 2024
ruthra-kumar
added a commit
that referenced
this pull request
Dec 27, 2024
…-44892 fix: clear payment schedule in purchase invoice for is_paid (backport #44892)
ruthra-kumar
added a commit
that referenced
this pull request
Dec 27, 2024
…-44892 fix: clear payment schedule in purchase invoice for is_paid (backport #44892)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Support Ticket - 25598
When
is_paidis marked for a purchase invoice, thepayment_terms_templatewas not cleared, which resulted in an error during the validation process.