fix (pos closing entry): validation for 100 pc discount on pos invoice (backport #44899) #44930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
mergify
bot
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following error occurs when a POS closing entry is submitted with a POS invoice with a 100% discount.
The above message is generated every time a POS Closing Entry is created. It validates that each Linked Sales Invoice generated through the POS has at least one associated
SalesInvoicePayment. However, for invoices that have a 100% discount, no payment is required and thus, noSalesInvoicePaymentdocument is appended to the Invoice.@nabinhait suggested that validation should only take place for invoices having a positive Grand Total to fix this issue.
This is an automatic backport of pull request #44899 done by Mergify.