Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serial and batch no. buttons on pos #45048

Merged

Conversation

diptanilsaha
Copy link
Contributor

@diptanilsaha diptanilsaha commented Jan 2, 2025

image

There was an issue with the buttons for adding serial or batch numbers—they were too large and not aligned, as shown in the screenshot on #44659.

I made the changes that maintain the size and alignment of the button as posted.


image

image

image

Copy link
Member

@nabinhait nabinhait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write some description of the changes, only screenshot is not suffice.

@frappe frappe deleted a comment from diptanilsaha Jan 7, 2025
@nabinhait nabinhait merged commit 31dd32d into frappe:develop Jan 7, 2025
13 checks passed
mergify bot pushed a commit that referenced this pull request Jan 7, 2025
rohitwaghchaure added a commit that referenced this pull request Jan 7, 2025
…-45048

fix: serial and batch no. buttons on pos (backport #45048)
frappe-pr-bot pushed a commit that referenced this pull request Jan 8, 2025
# [15.48.0](v15.47.5...v15.48.0) (2025-01-08)

### Bug Fixes

* add monthly distributation and write query in qb ([03b06fc](03b06fc))
* Alternative Item button dissapearing on Save event ([642b897](642b897))
* Alternative Items button in Work Order ([3194807](3194807))
* Bank Reconciliation Statement Report Company Filter ([622bfa6](622bfa6))
* consider expired batches in stock reco ([c924feb](c924feb))
* discount resetting on date change ([af53381](af53381)), closes [#44989](#44989)
* Hold_to_On_Hold ([9ecafdc](9ecafdc))
* ignore currency validation while canceling the voucher ([8874f4a](8874f4a))
* ignore party account validation while canceling the voucher ([0f1c6ff](0f1c6ff))
* invoice against purchase receipt with returned quantity ([9daabfc](9daabfc))
* issue in returning components against the SCO ([87405f0](87405f0))
* load price list rate for pos search term ([452dffa](452dffa))
* load search term price with customer default price list ([59af144](59af144))
* Missing company filter breaks `get_account_balance` in Bank Reco ([931b516](931b516))
* Override pre-commit behaviour due to conflicts with CI ([754845a](754845a))
* **Project:** make status in confirmation dialog translatable ([#45118](#45118)) ([0001d86](0001d86))
* removed unmerged patches ([4227d76](4227d76))
* resolved conflicts ([e9be858](e9be858))
* resolved conflicts ([7318748](7318748))
* Returned Qty in Work Order Consumed Materials report ([f7b501b](f7b501b))
* serial and batch no. buttons on pos ([#45048](#45048)) ([54e3a74](54e3a74))
* show new button in coa if create access ([89155f5](89155f5))
* update customer contact details on pos (backport [#45071](#45071)) ([#45106](#45106)) ([01254da](01254da))

### Features

* validate discount date in payment schedule (backport [#44646](#44646)) ([#44727](#44727)) ([500deff](500deff))
* work in progress status for asset ([#45066](#45066)) ([1ea36bb](1ea36bb))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants