-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set landed cost based on purchase invoice rate #45947
Conversation
) | ||
|
||
|
||
def execute(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run the patch only if "Set Landed Cost Based on Purchase Invoice Rate" in the buying settings has enabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User could have disabled the setting later on. By checking if "amount_difference_with_purchase_invoice" is set (> 0), we can know that when this PR/PI was created, the setting was on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mihir-kandoi hello when we get this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mihir-kandoi
hello, after patching, stock valuation is not correct yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thida-bcn please raise a ticket with the correct site on FC.
To prevent reposting of entries during closed periods we had taken many precautions. I suspect it has something to do with your issue.
8072f15
to
a410248
Compare
2f6eca5
to
154e981
Compare
7e43024
to
1230127
Compare
…-45947 fix: set landed cost based on purchase invoice rate (backport #45947)
@mihir-kandoi hello, good morning |
Reference support ticket 31369
The feature "Set Landed Cost Based on Purchase Invoice Rate" was not considering quantity of items when calculating the new incoming rate.
Note: This PR contains a patch