Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set landed cost based on purchase invoice rate #45947

Merged
merged 8 commits into from
Mar 5, 2025

Conversation

mihir-kandoi
Copy link
Contributor

Reference support ticket 31369

The feature "Set Landed Cost Based on Purchase Invoice Rate" was not considering quantity of items when calculating the new incoming rate.

Note: This PR contains a patch

)


def execute():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run the patch only if "Set Landed Cost Based on Purchase Invoice Rate" in the buying settings has enabled

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User could have disabled the setting later on. By checking if "amount_difference_with_purchase_invoice" is set (> 0), we can know that when this PR/PI was created, the setting was on.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mihir-kandoi hello when we get this one?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mihir-kandoi
hello, after patching, stock valuation is not correct yet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thida-bcn please raise a ticket with the correct site on FC.

To prevent reposting of entries during closed periods we had taken many precautions. I suspect it has something to do with your issue.

@rohitwaghchaure rohitwaghchaure merged commit 7012888 into frappe:develop Mar 5, 2025
13 checks passed
mihir-kandoi added a commit that referenced this pull request Mar 5, 2025
…-45947

fix: set landed cost based on purchase invoice rate (backport #45947)
@thida-bcn
Copy link

@mihir-kandoi hello, good morning
i had open new ticket 33498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants