fix: Add permission check in POS's Toggle Recent Orders (backport #46010)
#46273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit a08bc6b) # Conflicts: # erpnext/selling/page/point_of_sale/point_of_sale.py
|
Cherry-pick of a08bc6b has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
nabinhait
approved these changes
Mar 5, 2025
frappe-pr-bot
pushed a commit
that referenced
this pull request
Mar 5, 2025
## [14.83.2](v14.83.1...v14.83.2) (2025-03-05) ### Bug Fixes * Add permission check in POS's `Toggle Recent Orders` (backport [#46010](#46010)) ([#46273](#46273)) ([557a05b](557a05b)) * auto allocation for negative amount outstanding for Customers in Payment Entry ([8e02dcf](8e02dcf)) * change voucher_type and voucher_no field type to data ([df4f4d9](df4f4d9)) * consolidate gl entries by project in General Ledger Report (backport [#46314](#46314)) ([#46320](#46320)) ([b3b7e62](b3b7e62)) * do not include opening invoices in billed items to be received report ([cedf577](cedf577)) * don't allow renaming account while system is actively in use (backport [#46176](#46176)) ([#46209](#46209)) ([167069b](167069b)) * exclude cancelled gl entries ([369a692](369a692)) * incorrect batch picked in the pick list ([ac25d3e](ac25d3e)) * incorrectly billed amount in the purchase receipt ([ca94ad3](ca94ad3)) * inventory dimension for maintence visit ([69a8e0d](69a8e0d)) * only include submitted docs for internal received quantity validation (backport [#46262](#46262)) ([#46303](#46303)) ([90b5f0b](90b5f0b)) * **patch:** Ensure SLE indexes (backport [#46131](#46131)) ([#46134](#46134)) ([f8bbcab](f8bbcab)) ### Performance Improvements * don't track seen for POS Invoice (backport [#46187](#46187)) ([#46188](#46188)) ([b41ee66](b41ee66))
|
🎉 This PR is included in version 14.83.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support ticket: Support Ticket - 32187
In POS's
Toggle Recent Orders, permission was not checked, so all invoices were visible.So, use get_list instead of get_al to check for permissions.
This is an automatic backport of pull request #46010 done by [Mergify](https://mergify.com).