-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Debit and Credit mismatch on transaction currency debit and credit values (backport #46064) #46397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit b115bf2)
(cherry picked from commit e9af567)
(cherry picked from commit 7ff3977)
(cherry picked from commit ee93ed8)
(cherry picked from commit 3e292ef) # Conflicts: # erpnext/accounts/doctype/sales_invoice/sales_invoice.py
(cherry picked from commit d1d0688)
(cherry picked from commit 9f3847c)
(cherry picked from commit 5c86e3c)
(cherry picked from commit ceca5b4)
(cherry picked from commit a31770d)
(cherry picked from commit 23d4658)
(cherry picked from commit b348aa3)
(cherry picked from commit bc792c6)
(cherry picked from commit 6545467)
(cherry picked from commit 7528ef1)
(cherry picked from commit 4cd3f35)
(cherry picked from commit 455a55b)
(cherry picked from commit 55d0636)
(cherry picked from commit f1d8fee)
Cherry-pick of 3e292ef has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Debit and Credit values in Transaction currency have a slight mismatch on high precision exchange rates. This is un-fixable on the current approach.

Solution
Instead of calculating Transaction Debit and Credit from base currency, use values directly from parent document.
todo:
This is an automatic backport of pull request fix: Debit and Credit mismatch on transaction currency debit and credit values #46064 done by Mergify.