Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show hsn code in tax breakup for India and render via template #9866

Merged
merged 3 commits into from
Jul 17, 2017
Merged

Show hsn code in tax breakup for India and render via template #9866

merged 3 commits into from
Jul 17, 2017

Conversation

nabinhait
Copy link
Member

@nabinhait nabinhait commented Jul 14, 2017 •
edited
Loading

screen shot 2017-07-14 at 3 23 32 pm

@nabinhait nabinhait requested a review from mbauskar July 14, 2017 09:54
@frappe-pr-bot
Copy link
Collaborator

Pull Request Summary

Image or animted GIF Not Added

Please add an image or animated GIF as proof that you have manually tested this contribution. Hint: use LiceCAP to capture animated GIFs.

Test Case Not Added / Updated

Since you have changed a Python file, you must update the relevant python test case. If there is no test coverage for this code, then please add it.

Large Patch

This is a very large pull request, unless there is a very good reason, please try and break it down to smaller changes. Read this strategy on how it can be done

Demo not Updated

Since this is a large pull request, check if the demo is changed / updated

Result

  • Failed: User testing is mandatory for patches with changes in JS code.
  • Failed: Updating test cases is mandatory for large pull requests
  • Failed: User testing with animated GIF is mandatory for large pull requests.

This summary was automatically generated based on this script

@rmehta
Copy link
Member

rmehta commented Jul 17, 2017

check test.

@nabinhait nabinhait force-pushed the tax_breakup branch 2 times, most recently from 421e650 to f462bf8 Compare July 17, 2017 09:20
@mbauskar mbauskar added this to the 2017-07-18 milestone Jul 17, 2017
@mbauskar mbauskar merged commit b962fc1 into frappe:develop Jul 17, 2017
ashwinisave35 added a commit to ashwinisave35/erpnext that referenced this pull request Jul 18, 2017
@ashwinisave35
Merge branch 'develop' of https://github.com/frappe/erpnext into mobi…
711d1df 
…le_title_kb_btn

* 'develop' of https://github.com/frappe/erpnext: (22 commits)
  bumped to version 8.5.1
  [hotfix] set_restrict_to_domain_for_module_def patch fixes (frappe#9921)
  bumped to version 8.5.0
  [Fix] Sales invoice serial no validation issue
  [domainify] patch to set the restrict to domain for module_def (frappe#9912)
  Remove newline from serial no values
  [minor] default qty 0, fixes frappe#9880
  [batch modal] bind serial_no field in onchange
  [minor] fixes for TypeError: get_lead_details() takes at least 1 argument (2 given)
  Update stock_balance.py
  [fix] filters for calendars frappe#9850 (frappe#9870)
  Sales Goal by Company (frappe#9723)
  Removed a deprecated function call
  code fix as per review
  Show hsn code in tax breakup for India and render via template (frappe#9866)
  Revert "adds if statement for `reference_type` === "Asset""
  [Translation] Updated Translations (frappe#9898)
  [fix] frappe#9899
  test cases
  [Fix] Expense claim status issue
  ...
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbauskar mbauskar mbauskar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2017-07-18
Development

Successfully merging this pull request may close these issues.
4 participants
@nabinhait @frappe-pr-bot @rmehta @mbauskar