chore(socketio): remove duplicate event handler #18770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagarvora
requested review from
a team and
shariquerik
and removed request for
a team
sagarvora
added
backport version-13-hotfix
backport version-14-hotfix
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #18770 +/- ##
===========================================
+ Coverage 63.13% 63.20% +0.06%
===========================================
Files 747 747
Lines 67329 67329
Branches 5999 5999
===========================================
+ Hits 42510 42557 +47
+ Misses 21324 21302 -22
+ Partials 3495 3470 -25
Flags with carried forward coverage won't be shown. Click here to find out more. |
ankush
approved these changes
Nov 5, 2022
mergify bot
pushed a commit
that referenced
this pull request
Nov 5, 2022
(cherry picked from commit ff0c820)
ankush
pushed a commit
that referenced
this pull request
Nov 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also has a bit of reorganising.