Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: bump pyjwt #22882

Merged
merged 2 commits into from
Oct 24, 2023
Merged

build: bump pyjwt #22882

merged 2 commits into from
Oct 24, 2023

Conversation

ankush
Copy link
Member

@ankush ankush commented Oct 24, 2023

  • chore: Update PyJWT dependency
  • chore: bump PyJWT further to match v14

gavindsouza and others added 2 commits October 24, 2023 12:35
@gavindsouza @ankush
chore: Update PyJWT dependency
929ae06 
* Update pinned dep fromm 1.7.1 to 2.0.1
* Updated usages as per changelog

ref: https://python.libhunt.com/pyjwt-changelog
@ankush
chore: bump PyJWT further to match v14
4b0044c
@ankush ankush requested review from a team and shariquerik and removed request for a team October 24, 2023 07:08
@ankush ankush merged commit df2a863 into frappe:version-13-hotfix Oct 24, 2023
7 of 8 checks passed
@ankush ankush deleted the bump_pyjwt branch October 24, 2023 16:07
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 13.58.16 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@SanderVanDenBerk
Copy link

Hee,
I was updating my ERPNext server (version 13) and I am getting an error when building the server. The version of PyJWT in frappe is updated to 2.4.0 but the version in ERPNext is still on < 2.0 (for the PyGithub 1.54.1). Now I am getting a conflict when updating.
Any tips???

@ankush
Copy link
Member Author

ankush commented Oct 31, 2023

@SanderVanDenBerk is it blocking install? if not, you can ignore the warning.

@ankush ankush mentioned this pull request Oct 31, 2023
Merged
@SanderVanDenBerk
Copy link

It is blocking the update. Bench is not working after the error.

image

Frappe is not installed correctly in python. The Frappe 0.0.1 should be 13.58.16.
image

@ankush
Copy link
Member Author

ankush commented Oct 31, 2023

this should fix it i think: frappe/erpnext#37800

In meantime you can also just remove it from requirements.txt if you want to move ahead for now.

@ankush
Copy link
Member Author

ankush commented Oct 31, 2023

Frappe is not installed correctly in python. The Frappe 0.0.1 should be 13.58.16.

You've probably fetched frappe from pypi somehow. do bench pip uninstall frappe and bench pip install -e ./apps/frappe to reinstall it correctly.

@SanderVanDenBerk
Copy link

Uninstalling and installing frappe will work and this will fix bench partially, thanks. I have updated PyGithub to 2.1.1. This works a little bit better because this will remove all of the warnings and error in the update.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shariquerik shariquerik Awaiting requested review from shariquerik

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ankush @frappe-pr-bot @SanderVanDenBerk @gavindsouza