New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: re-enable workspaces #278

Open

blaggacao wants to merge 5 commits into frappe:main from blaggacao:revert/re-enable-workspaces

Contributor

blaggacao commented Mar 23, 2024

The original "chore" commit didn't specify a specific reason.

On the other hand, the lack of a proper workspace configuration breaks the Frappix build of Gameplan.

This PR re-instates the workspaces and heals Frappix builds of Gameplan

blaggacao force-pushed the revert/re-enable-workspaces branch 2 times, most recently from f36cc1c to 9a7b551 Compare

March 23, 2024 15:48

cypress bot commented Mar 23, 2024 •

edited

Loading

5 failed tests on run #248 ↗︎

5	1	0	0	0

Details:

Merge `41b5936` into `d357258`...
Project: gameplan	Commit: `2b8d445c85 ℹ️`
Status: Failed	Duration: 02:40 💡
Started: Jul 23, 2024 1:43 AM	Ended: Jul 23, 2024 1:46 AM

discussion.cy.js • 1 failed test

View Output Video

Test		Artifacts
Discussion > all discussion actions		`Screenshots` `Video`

onboarding.cy.js • 1 failed test

View Output Video

Test		Artifacts
Onboarding > onboarding works		`Screenshots` `Video`

project.cy.js • 1 failed test

View Output Video

Test		Artifacts
Project > project creation, move to team and archive		`Screenshots` `Video`

task.cy.js • 1 failed test

View Output Video

Test		Artifacts
Task > task actions		`Screenshots` `Video`

team.cy.js • 1 failed test

View Output Video

Test		Artifacts
Team > team creation, readme edit and archive		`Screenshots` `Video`

Review all test suite changes for PR #278 ↗︎

blaggacao force-pushed the revert/re-enable-workspaces branch from 9a7b551 to 511fe16 Compare

May 30, 2024 14:15

blaggacao added a commit to blaggacao/frappix that referenced this pull request


          update(gameplan): incorporate latest refactoring

996ea62

see also: frappe/gameplan#278

Contributor Author

blaggacao commented May 30, 2024

@netchampfaris I removed the motion stuff. I guess this could now be re-considered? It would really help me to package Gameplan in Frappix.

Contributor Author

blaggacao commented Jun 16, 2024

@netchampfaris Could this be reconsidered? It's kind of a particular interest requirement, but given that the other new style apps use workspaces (afaik: Crm, Builder & Insights) there might be an independent value on aligning the code layout between projects.

As a collateral it would really help me package GamePlan properly for Frappix. 😄

Contributor Author

blaggacao commented Jun 23, 2024

ping

Contributor Author

blaggacao commented Jun 28, 2024

Go for it now. The future is promised to no one. - Wayne Dyer

_{Kindly help move this PR forward. Many thanks from Yours Sincerely!}

blaggacao force-pushed the revert/re-enable-workspaces branch 2 times, most recently from 0ff6746 to 81649f6 Compare

July 2, 2024 18:03

Contributor Author

blaggacao commented Jul 4, 2024

Fears are nothing more than a state of mind. - Napoleon Hill

_{Kindly help move this PR forward. Many thanks from Yours Sincerely!}

Contributor Author

blaggacao commented Jul 11, 2024

What the caterpillar calls the end of the world, the master calls a butterfly. - Richard Bach

_{Kindly help move this PR forward. Many thanks from Yours Sincerely!}

Contributor Author

blaggacao commented Jul 18, 2024

Watch your thoughts, they become your words Watch your words, they become your actions Watch your actions, they become your habits Watch your habits, they become your character Watch your character, it becomes your destiny. -

_{Kindly help move this PR forward. Many thanks from Yours Sincerely!}

Contributor Author

blaggacao commented Jul 22, 2024

You may say Im a dreamer, but Im not the only one, I hope someday you will join us, and the world will live as one. - John Lennon

_{Kindly help move this PR forward. Many thanks from Yours Sincerely!}

blaggacao force-pushed the revert/re-enable-workspaces branch from 81649f6 to 6411b36 Compare

July 22, 2024 19:07

blaggacao added 4 commits

July 23, 2024 02:25


          fix: task detail

afd8e88


          fix: pop up actions

3059dad


          ci: fix

538fee4


          fix: router problems via a dependency update

34d4b8c

blaggacao force-pushed the revert/re-enable-workspaces branch from 6411b36 to 34d4b8c Compare

July 23, 2024 00:27


          fix: expand/collapse toggle

41b5936

Contributor Author

blaggacao commented Jul 29, 2024

I have just three things to teach: simplicity, patience, compassion. These three are your greatest treasures. - Lao Tzu

_{Kindly help move this PR forward. Many thanks from Yours Sincerely!}

Contributor Author

blaggacao commented Jul 29, 2024

@netchampfaris Could you please verify if 41b5936 is also an independent fix? Thank you!

Contributor Author

blaggacao commented Aug 2, 2024

The important thing is this: to be able at any moment to sacrifice what we are for what we could become. - Charles Dubois

_{Kindly help move this PR forward. Many thanks from Yours Sincerely!}

Contributor Author

blaggacao commented Aug 5, 2024

Obstacles are those frightful things you see when you take your eyes off your goal. - Henry Ford

_{Kindly help move this PR forward. Many thanks from Yours Sincerely!}

Contributor Author

blaggacao commented Aug 9, 2024

Our distrust is very expensive. - Ralph Emerson

_{Kindly help move this PR forward. Many thanks from Yours Sincerely!}

Contributor Author

blaggacao commented Aug 25, 2024

An invincible determination can accomplish almost anything and in this lies the great distinction between great men and little men. - Thomas Fuller

_{Kindly help move this PR forward. Many thanks from Yours Sincerely!}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet