Update bookmarks #343
Open
Update bookmarks #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyshaHakeem
requested review from
netchampfaris
and removed request for
netchampfaris
gameplan
|
||||||||||||||||||||||||||||
| Project |
gameplan
|
| Branch Review |
refs/pull/343/merge
|
| Run status |
|
| Run duration | 02m 02s |
| Commit |
|
| Committer | Aysha |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
6
|
| View all changes introduced in this branch ↗︎ | |
netchampfaris
requested changes
Nov 18, 2024
| @@ -459,69 +459,23 @@ def search(query, start=0): | |||
|
|
|||
|
|
|||
| @frappe.whitelist() | |||
| def check_bookmark(discussionId): | |||
There was a problem hiding this comment.
All python files use tab indentations. It seems your editor has converted it into spaces.
| DesktopLayout: typeof import('./src/components/DesktopLayout.vue')['default'] | ||
| DiscussionBreadcrumbs: typeof import('./src/components/DiscussionBreadcrumbs.vue')['default'] | ||
| DiscussionList: typeof import('./src/components/DiscussionList.vue')['default'] | ||
| DiscussionListByData: typeof import('./src/components/DiscussionListByData.vue')['default'] |
There was a problem hiding this comment.
A single line change shouldn't affect other lines in a commit. This messes up git blame. If you want to format the other lines, do it in another commit.
| @@ -0,0 +1,114 @@ | |||
| <template> | |||
There was a problem hiding this comment.
This is a duplicate of DiscussionList without the data fetching. The correct way for this refactor is to make DiscussionList use DiscussionListByData.
Also, DiscussionList is a better name for a component that only renders UI and data fetching can be done separately.
| @@ -125,6 +119,7 @@ import ImagePreview from '../components/ImagePreview.vue' | |||
| import ColorPicker from '@/components/ColorPicker.vue' | |||
| import ProfileImageEditor from '@/components/ProfileImageEditor.vue' | |||
| import UserImage from '@/components/UserImage.vue' | |||
| import DiscussionListByData from '@/components/DiscussionListByData.vue' | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor code for bookmarking discussions.