Fix regression with webpack #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some entries to `package.json` to improve compatibility with webpack - Add `import` export as per webpack requirements - Add `style` export for CSS file - Add `*.css` to "side effects" to prevent issues with tree-shaking With this commit, it is possible to import frappe-gantt without breaking changes in webpack-based applications Refs: - https://webpack.js.org/guides/package-exports/ Close frappe#439
tagliala
force-pushed
the
chore/import-directive-webpack
branch
from
0325398 to
c88e8fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some entries to
package.jsonto improve compatibility with webpackimportexport as per webpack requirementsstyleexport for CSS file*.cssto "side effects" to prevent issues with tree-shakingWith this commit, it is possible to import frappe-gantt without breaking changes in webpack-based applications
Refs:
Close #439