Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PWA): Allow login using OAuth #2091

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

cogk
Copy link
Contributor

@cogk cogk commented Aug 16, 2024

closes #1908

localhost_8080_hrms_login(Pixel 3)

no-docs

@cogk cogk requested a review from ruchamahabal as a code owner August 16, 2024 17:16
@cogk cogk force-pushed the feat-pwa-login-via-oauth branch from bd8ae7b to c6b21b1 Compare August 22, 2024 12:29
@krantheman krantheman self-assigned this Oct 17, 2024
@krantheman
Copy link
Member

Looks good 👍

Can you make the social logins section similar to that in desk - by adding the 'or'

image

Also, can you fix the conflicts?

@cogk cogk force-pushed the feat-pwa-login-via-oauth branch from c6b21b1 to a90f2a8 Compare October 17, 2024 12:44
@krantheman krantheman merged commit 9f2200e into frappe:develop Oct 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PWA] doesn't have social login
3 participants