fix(Payroll): incorrect tax period calculation when payroll period starts after the first day of the month #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r first day of a month - framework's month_diff counts both start & end dates months as inclusive - count the last month only if end date's day > start date's day to handle cases like 16th Jul 2024 - 15th Jul 2025, where framework's month_diff will calculate diff as 13 months
ruchamahabal
changed the title
ruchamahabal
added a commit
that referenced
this pull request
Aug 28, 2024
…2130 fix(Payroll): incorrect tax period calculation when payroll period starts after the first day of the month (backport #2130)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1992 Closes #837
If payroll period is from
16th July 2024 - 15th July 2025
Tax period gets calculated as 13 months because of the
month_difffunction in the framework leading to incorrect CTC calculation and thereby incorrect tax breakupBefore:
After:
There was attempt to fix this in the framework frappe/frappe#10938 but the inclusion of both the months is on purpose and this function doesn't exactly consider the dates. Wrote a custom helper function to handle this case for payroll