fix(Payroll): calculate loan repayment amount based on payroll end date instead of posting date #2154
Conversation
…te instead of posting date - for backdated salary slips fetching loan repayments based on posting date leads to more deductions than earnings sometimes. Process this relative to the payroll dates instead of posting date
- doing extra actions in a function named get is misleading
ruchamahabal
force-pushed
the
fix-loan-fetching
branch
from
29a3dab to
5e16f28
Compare
…te instead of posting date (#2154) * fix(Payroll): calculate loan repayment amount based on payroll end date instead of posting date - for backdated salary slips fetching loan repayments based on posting date leads to more deductions than earnings sometimes. Process this relative to the payroll dates instead of posting date * refactor: move out process accrual entries from `get_loan_details` - doing extra actions in a function named get is misleading (cherry picked from commit 5669fab)
…te instead of posting date (backport #2154) (#2156) * fix(Payroll): calculate loan repayment amount based on payroll end date instead of posting date - for backdated salary slips fetching loan repayments based on posting date leads to more deductions than earnings sometimes. Process this relative to the payroll dates instead of posting date * refactor: move out process accrual entries from `get_loan_details` - doing extra actions in a function named get is misleading (cherry picked from commit 5669fab) Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
## [15.28.2](v15.28.1...v15.28.2) (2024-09-04) ### Bug Fixes * **Employee Checkin:** set the form as dirty on fetching geolocation (backport [#2157](#2157)) ([#2158](#2158)) ([3598ae9](3598ae9)) * **Payroll:** calculate loan repayment amount based on payroll end date instead of posting date (backport [#2154](#2154)) ([#2156](#2156)) ([020344d](020344d)) * **Payroll:** skip dependent component update if no formula is set (backport [#2152](#2152)) ([#2153](#2153)) ([190959f](190959f))
|
@ruchamahabal This PR broke our workflow. We process salary on the last working day of a month, and for calculation, we take the data till the previous working day. The reason that we can't include final salary processing day (October 31st) for the Salary Process End date is because it'll include partial timesheet data, which we are trying to avoid. Any suggestion or workarounds you can suggest? |
Steps to replicate
Loan Repayment Schedule:
Monthly repayment amount is 2000
Backdated salary slip:
For April 2024 generated in Sept 2024. Since all loan interest accruals have been processed by sept, loan amount shows up as 10000 for a backdated salary slip:
Fix
Calculate loan repayment amount based on payroll end date instead of posting date
For backdated salary slips fetching loan repayments based on posting date seems incorrect and leads to more deductions than earnings sometimes. Process this relative to the payroll dates instead of posting date