-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: process leave encashment via payment entry #2775
Merged
AyshaHakeem
merged 16 commits into
frappe:develop
from
AyshaHakeem:feat-process-leave-encashment-via-journal-entry
Feb 21, 2025
Merged
feat: process leave encashment via payment entry #2775
AyshaHakeem
merged 16 commits into
frappe:develop
from
AyshaHakeem:feat-process-leave-encashment-via-journal-entry
Feb 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d and other changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hrms/patches/v15_0/update_payment_status_for_leave_encashment
It's a .py file. Please add extension.
nabinhait
requested changes
Feb 21, 2025
51cf0fe
to
fa49658
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Leave Encashment was always processed by creating an Additional Salary on submission, which was later paid through the Salary Slip.
Patch to update payment status of existing, submitted leave encashment docs based on whether they have been paid via salary slip
Before:

No status tracking, only Salary Slip-based payment.
After:

Documentation Link: https://docs.frappe.io/hr/leave-encashment