fix: clear loans on employee and salary slip date change #2810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
added
backport version-14-hotfix
backport version-15-hotfix
and removed
needs-tests
labels
ruchamahabal
approved these changes
Feb 28, 2025
This was referenced Feb 28, 2025
ruchamahabal
added a commit
that referenced
this pull request
Feb 28, 2025
…2810 fix: clear loans on employee and salary slip date change (backport #2810)
ruchamahabal
added a commit
that referenced
this pull request
Feb 28, 2025
…2810 fix: clear loans on employee and salary slip date change (backport #2810)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
set_loan_repaymentfunction insalary_slip_loan_utils.pydoesn't update loans field if it is already populated.this can create a bug that the loans field is not updated if employee or date of salary slip is changes.
this will create another bug that the loan is repaid with another employees salary if the employee field is changed.
this fix clears the loans field if employee or end date of salary slip is changed.
Please
backport version-15-hotfix
backport version-14-hotfix