Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close employee loan on write off [v14] #990

Merged
merged 1 commit into from
Nov 1, 2023
Merged

fix: close employee loan on write off [v14] #990

merged 1 commit into from
Nov 1, 2023

Conversation

anandbaburajan
Copy link
Contributor

Now employee loans would be auto closed after write off if there's no pending principal amount.

Depends on frappe/erpnext#37638.

@codecov-commenter
Copy link

Codecov Report

Merging #990 (ecc06eb) into version-14-hotfix (e756376) will increase coverage by 0.04%.
Report is 8 commits behind head on version-14-hotfix.
The diff coverage is 100.00%.

@@                  Coverage Diff                  @@
##           version-14-hotfix     #990      +/-   ##
=====================================================
+ Coverage              73.80%   73.84%   +0.04%     
=====================================================
  Files                    193      193              
  Lines                  10066    10084      +18     
=====================================================
+ Hits                    7429     7447      +18     
  Misses                  2637     2637              
Files Coverage Δ
hrms/hooks.py 100.00% <ø> (ø)
hrms/overrides/employee_master.py 62.66% <100.00%> (+11.78%) ⬆️
hrms/payroll/doctype/salary_slip/salary_slip.py 87.01% <ø> (ø)

@ruchamahabal ruchamahabal merged commit 245944d into frappe:version-14-hotfix Nov 1, 2023
8 checks passed
frappe-pr-bot pushed a commit that referenced this pull request Nov 1, 2023
# [14.15.0](v14.14.0...v14.15.0) (2023-11-01)

### Bug Fixes

* close employee loan on write off ([#990](#990)) ([245944d](245944d))

### Features

* Add Select/Unselect All options in Mark Attendance Dialog ([#1005](#1005)) ([#1006](#1006)) ([ee15df8](ee15df8))
* Add sender in payroll setting & HR Setting ([0565dbf](0565dbf))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants