fix: installation on site with db_name containing special chars

frappe · Nov 25, 2024 · 05f8ccb · 05f8ccb
1 parent 52725b5
commit 05f8ccb
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/insights/insights/doctype/insights_data_source_v3/insights_data_source_v3.py b/insights/insights/doctype/insights_data_source_v3/insights_data_source_v3.py
@@ -209,11 +209,14 @@ def _get_connection_string(self):
         frappe.throw(f"Unsupported database type: {self.database_type}")
 
     def get_quoted_db_name(self):
-        if not self.database_name:
+        database_name = self.database_name
+        if self.is_site_db:
+            database_name = frappe.conf.db_name
+        if not database_name:
             return None
         quote_start = self._get_ibis_backend().dialect.QUOTE_START
         quote_end = self._get_ibis_backend().dialect.QUOTE_END
-        return f"{quote_start}{self.database_name}{quote_end}"
+        return f"{quote_start}{database_name}{quote_end}"
 
     def test_connection(self, raise_exception=False):
         try: