fix: correct spelling of DonutChartConfig

frappe · Dec 23, 2024 · 681ff26 · 681ff26
1 parent d9a6638
commit 681ff26
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 14 deletions.
diff --git a/frontend/src2/charts/chart.ts b/frontend/src2/charts/chart.ts
@@ -7,7 +7,7 @@ import { getCachedQuery, makeQuery, Query } from '../query/query'
 import {
 	AXIS_CHARTS,
 	AxisChartConfig,
-	DountChartConfig,
+	DonutChartConfig,
 	NumberChartConfig,
 	TableChartConfig
 } from '../types/chart.types'
@@ -93,7 +93,7 @@ function makeChart(workbookChart: WorkbookChart) {
 			const _config = unref(chart.doc.config as NumberChartConfig)
 			prepared = prepareNumberChartQuery(_config)
 		} else if (chart.doc.chart_type === 'Donut' || chart.doc.chart_type === 'Funnel') {
-			const _config = unref(chart.doc.config as DountChartConfig)
+			const _config = unref(chart.doc.config as DonutChartConfig)
 			prepared = prepareDonutChartQuery(_config)
 		} else if (chart.doc.chart_type === 'Table') {
 			const _config = unref(chart.doc.config as TableChartConfig)
@@ -174,7 +174,7 @@ function makeChart(workbookChart: WorkbookChart) {
 		return true
 	}
 
-	function prepareDonutChartQuery(config: DountChartConfig) {
+	function prepareDonutChartQuery(config: DonutChartConfig) {
 		if (!config.label_column) {
 			console.warn('Label is required')
 			chart.dataQuery.reset()

diff --git a/frontend/src2/charts/components/ChartConfigForm.vue b/frontend/src2/charts/components/ChartConfigForm.vue
@@ -2,7 +2,7 @@
 import { computed } from 'vue'
 import {
 	BarChartConfig,
-	DountChartConfig,
+	DonutChartConfig,
 	FunnelChartConfig,
 	LineChartConfig,
 	NumberChartConfig,
@@ -41,7 +41,7 @@ const columnOptions = computed(() => {
 	/>
 	<DonutChartConfigForm
 		v-if="props.chart.doc.chart_type == 'Donut'"
-		v-model="(props.chart.doc.config as DountChartConfig)"
+		v-model="(props.chart.doc.config as DonutChartConfig)"
 		:dimensions="dimensions"
 		:column-options="columnOptions"
 	/>

diff --git a/frontend/src2/charts/components/ChartRenderer.vue b/frontend/src2/charts/components/ChartRenderer.vue
@@ -4,7 +4,7 @@ import { computed, ref } from 'vue'
 import {
 	BarChartConfig,
 	ChartType,
-	DountChartConfig,
+	DonutChartConfig,
 	FunnelChartConfig,
 	LineChartConfig,
 	NumberChartConfig,
@@ -45,7 +45,7 @@ const eChartOptions = computed(() => {
 		return getLineChartOptions(props.config as LineChartConfig, props.result)
 	}
 	if (props.chart_type === 'Donut') {
-		return getDonutChartOptions(props.config as DountChartConfig, props.result)
+		return getDonutChartOptions(props.config as DonutChartConfig, props.result)
 	}
 	if (props.chart_type === 'Funnel') {
 		return getFunnelChartOptions(props.config as FunnelChartConfig, props.result)

diff --git a/frontend/src2/charts/components/DonutChartConfigForm.vue b/frontend/src2/charts/components/DonutChartConfigForm.vue
@@ -1,7 +1,7 @@
 <script setup lang="ts">
 import { computed, watchEffect } from 'vue'
 import { FIELDTYPES } from '../../helpers/constants'
-import { DountChartConfig } from '../../types/chart.types'
+import { DonutChartConfig } from '../../types/chart.types'
 import { ColumnOption, Dimension, DimensionOption, Measure } from '../../types/query.types'
 import CollapsibleSection from './CollapsibleSection.vue'
 import DimensionPicker from './DimensionPicker.vue'
@@ -12,7 +12,7 @@ const props = defineProps<{
 	columnOptions: ColumnOption[]
 }>()
 
-const config = defineModel<DountChartConfig>({
+const config = defineModel<DonutChartConfig>({
 	required: true,
 	default: () => ({
 		label_column: {},

diff --git a/frontend/src2/charts/helpers.ts b/frontend/src2/charts/helpers.ts
@@ -7,7 +7,7 @@ import {
 	AxisChartConfig,
 	BarChartConfig,
 	ChartConfig,
-	DountChartConfig,
+	DonutChartConfig,
 	LineChartConfig,
 	Series,
 	SeriesLine,
@@ -295,7 +295,7 @@ function getYAxis(options: YAxisCustomizeOptions = {}) {
 	}
 }
 
-export function getDonutChartOptions(config: DountChartConfig, result: QueryResult) {
+export function getDonutChartOptions(config: DonutChartConfig, result: QueryResult) {
 	const columns = result.columns
 	const rows = result.rows
 
@@ -442,7 +442,7 @@ function getDonutChartData(
 	return topData
 }
 
-export function getFunnelChartOptions(config: DountChartConfig, result: QueryResult) {
+export function getFunnelChartOptions(config: DonutChartConfig, result: QueryResult) {
 	const rows = result.rows
 
 	const labelColumn = config.label_column.dimension_name

diff --git a/frontend/src2/types/chart.types.ts b/frontend/src2/types/chart.types.ts
@@ -79,7 +79,7 @@ export type NumberColumnOptions = {
 	suffix?: string
 }
 
-export type DountChartConfig = {
+export type DonutChartConfig = {
 	label_column: Dimension
 	value_column: Measure
 	legend_position?: 'top' | 'bottom' | 'left' | 'right'
@@ -100,4 +100,4 @@ export type TableChartConfig = {
 	enable_color_scale?: boolean
 }
 
-export type ChartConfig = LineChartConfig | BarChartConfig | NumberChartConfig | DountChartConfig | TableChartConfig | FunnelChartConfig
+export type ChartConfig = LineChartConfig | BarChartConfig | NumberChartConfig | DonutChartConfig | TableChartConfig | FunnelChartConfig