fix: reduce redundant fetch request

frappe · Nov 20, 2024 · ae0bc8e · ae0bc8e
1 parent 899c68b
commit ae0bc8e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/frontend/src/dashboard/useDashboard.js b/frontend/src/dashboard/useDashboard.js
@@ -306,6 +306,7 @@ function getDashboardResource(name) {
 	return createDocumentResource({
 		doctype: 'Insights Dashboard',
 		name: name,
+		auto: false,
 		whitelistedMethods: {
 			fetch_chart_data: 'fetch_chart_data',
 			clear_charts_cache: 'clear_charts_cache',

diff --git a/frontend/src/widgets/useChartData.js b/frontend/src/widgets/useChartData.js
@@ -27,11 +27,14 @@ export default function useChartData(options = {}) {
 		error: null,
 	})
 
+	let currentLoadPromise = null
 	function load(query) {
 		if (!query) return
 		state.loading = true
-		return options
-			.resultsFetcher()
+		if (!currentLoadPromise) {
+			currentLoadPromise = options.resultsFetcher(query)
+		}
+		return currentLoadPromise
 			.then((results) => {
 				state.loading = false
 				state.rawData = getFormattedResult(results)
@@ -41,6 +44,9 @@ export default function useChartData(options = {}) {
 				state.loading = false
 				state.error = error
 			})
+			.finally(() => {
+				currentLoadPromise = null
+			})
 	}
 
 	if (options.query) {