Skip to content

Commit

Permalink
fix: ignore errors when executing drill down query in shared charts
Browse files Browse the repository at this point in the history
  • Loading branch information
nextchamp-saqib committed Dec 9, 2024
1 parent 025376d commit b23a3eb
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
10 changes: 8 additions & 2 deletions frontend/src2/charts/components/DrillDown.vue
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,14 @@ watch(
)
if (query) {
drillDownQuery.value = query
drillDownQuery.value.execute()
showDrillDownResults.value = true
drillDownQuery.value
.execute()
.then(() => {
showDrillDownResults.value = true
})
.catch(() => {
showDrillDownResults.value = false
})
}
},
{ immediate: true, deep: true }
Expand Down
5 changes: 0 additions & 5 deletions frontend/src2/query/query.ts
Original file line number Diff line number Diff line change
Expand Up @@ -202,11 +202,6 @@ export function makeQuery(workbookQuery: WorkbookQuery) {
const queryTable = getCachedQuery(op.table.query_name)
if (!queryTable) {
const message = `Query ${op.table.query_name} not found`
createToast({
variant: 'error',
title: 'Error',
message,
})
throw new Error(message)
}

Expand Down

0 comments on commit b23a3eb

Please sign in to comment.