Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable pagination and resolve sorting issue in DataTable for Query Editor #415

Conversation

UmakanthKaspa
Copy link
Contributor

Summary

This PR addresses two key improvements in the Query Editor's DataTable component:

  1. Enable Pagination: Ensures all rows are accessible in the DataTable by enabling pagination.
  2. Resolve Sorting Issue: Implements dynamic query updates for column sorting, allowing users to sort data by ascending, descending, or default order.

Before:

before.webm

After:

after.webm

@nextchamp-saqib nextchamp-saqib merged commit 1e8c0f4 into frappe:develop Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants