Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: evaluation error message issue #1030

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

pateljannat
Copy link
Collaborator

When a student tried scheduling an evaluation after the Evaluation End Date, the error message was not visible. There was an error in the console.

Screenshot 2024-09-25 at 11 10 51 AM

Copy link

cypress bot commented Sep 25, 2024

lms    Run #693

Run Properties:  status check passed Passed #693  •  git commit c103383515 ℹ️: Merge 33c76e842f1e244ae91f1a77e43d3cee05b30e62 into 04552bdef6e2921fa2c761c20d22...
Project lms
Branch Review fix-evaluation-issue
Run status status check passed Passed #693
Run duration 00m 43s
Commit git commit c103383515 ℹ️: Merge 33c76e842f1e244ae91f1a77e43d3cee05b30e62 into 04552bdef6e2921fa2c761c20d22...
Committer Jannat Patel
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎

@pateljannat pateljannat merged commit 41ad3d0 into frappe:develop Sep 25, 2024
5 checks passed
@pateljannat pateljannat deleted the fix-evaluation-issue branch September 25, 2024 05:59
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 2.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants