Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: misc issues #1056

Merged
merged 2 commits into from
Oct 10, 2024
Merged

fix: misc issues #1056

merged 2 commits into from
Oct 10, 2024

Conversation

pateljannat
Copy link
Collaborator

  1. There will be a prompt before deleting the lessons.
Screenshot 2024-10-10 at 4 27 21 PM
  1. Video player controls will now only be visible when the video is hovered.
  2. Also directly clicking anywhere on the video plays and pauses it.
  3. Job details page now has colored icon to improve cognitive load.
  4. Replaced FrappeTestCase with UnitTestCase.

@cypress Cypress
Copy link

cypress bot commented Oct 10, 2024

lms    Run #724

Run Properties:  status check passed Passed #724  •  git commit 1937d33c36 ℹ️: Merge 675bcc8956cbaa665568eab480c5e1693a62bc20 into c76d8c582f131cc6be70711afb5b...
Project lms
Run status status check passed Passed #724
Run duration 00m 29s
Commit git commit 1937d33c36 ℹ️: Merge 675bcc8956cbaa665568eab480c5e1693a62bc20 into c76d8c582f131cc6be70711afb5b...
Committer Jannat Patel
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1

@pateljannat pateljannat merged commit 016dafb into frappe:develop Oct 10, 2024
5 checks passed
@pateljannat pateljannat deleted the issues-41 branch October 10, 2024 11:14
@pateljannat pateljannat mentioned this pull request Oct 10, 2024
Closed
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 2.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pateljannat @frappe-pr-bot