Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: misc issues #1133

Merged
merged 2 commits into from
Nov 18, 2024
Merged

fix: misc issues #1133

merged 2 commits into from
Nov 18, 2024

Conversation

pateljannat
Copy link
Collaborator

@pateljannat pateljannat commented Nov 15, 2024 •
edited
Loading

  1. Removed focus from chapter title field in chapter modal.
  2. Instructors were unable to see the new course creation button. They can now see the button with this fix.
  3. Minimum 2 options for choices were not getting validated.

@cypress Cypress
Copy link

cypress bot commented Nov 15, 2024 •
edited
Loading

lms    Run #825

Run Properties:  status check passed Passed #825  •  git commit 69b34f36c3 ℹ️: Merge 52bd9825d8f3293d6b296928425f58413346fd27 into dfb22c81c3c3cd9d4d9f569847dd...
Project lms
Branch Review issues-50
Run status status check passed Passed #825
Run duration 00m 30s
Commit git commit 69b34f36c3 ℹ️: Merge 52bd9825d8f3293d6b296928425f58413346fd27 into dfb22c81c3c3cd9d4d9f569847dd...
Committer Jannat Patel
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎

@pateljannat pateljannat merged commit 3faf814 into frappe:develop Nov 18, 2024
5 checks passed
@pateljannat pateljannat mentioned this pull request Nov 18, 2024
Merged
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 2.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pateljannat @frappe-pr-bot