Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show notification count at the top in collapsed #1137

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

iamejaaz
Copy link
Contributor

@iamejaaz iamejaaz commented Nov 17, 2024

Closes #1043

  • Show the notification count at the top in collapsed mode when it is greater than 9.
Screen.Recording.2024-11-17.at.7.14.54.PM.mov

Copy link

cypress bot commented Nov 17, 2024

lms    Run #824

Run Properties:  status check passed Passed #824  •  git commit 41874b6249 ℹ️: Merge b6028e741c28a525811ae78c0a857f9d5df586b6 into dfb22c81c3c3cd9d4d9f569847dd...
Project lms
Branch Review notification-sidebar-ui
Run status status check passed Passed #824
Run duration 00m 41s
Commit git commit 41874b6249 ℹ️: Merge b6028e741c28a525811ae78c0a857f9d5df586b6 into dfb22c81c3c3cd9d4d9f569847dd...
Committer Ejaaz Khan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎

@pateljannat pateljannat merged commit b1a0556 into frappe:develop Nov 19, 2024
5 checks passed
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 2.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar width UI Issue
3 participants