Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Restore Site)!: Restore site config from backup #2213

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cogk
Copy link
Contributor

@cogk cogk commented Oct 10, 2024

Restore the site_config.json file in the Restore Site agent job. I don't know why it was not done in Restore Site, but correctly done in New Site from Backup. If anyone knows if it's just an oversight or if it's intentional, I'm eager to know. :)

@cogk cogk changed the title feat!: Restore site config from backup feat(Restore Site)!: Restore site config from backup Oct 10, 2024
@cogk
Copy link
Contributor Author

cogk commented Oct 11, 2024

Should probably drop the following keys from the site config before restoring:

  • monitor
  • redis_cache
  • redis_queue
  • redis_socketio
  • shallow_clone
  • socketio_port
  • webserver_port

@cogk cogk marked this pull request as draft October 11, 2024 14:31
@cogk cogk force-pushed the feat-restore-site-config branch from e35efd2 to c1f5070 Compare October 14, 2024 14:52
@cogk cogk force-pushed the feat-restore-site-config branch from c1f5070 to 6e43eb0 Compare November 29, 2024 16:43
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 42.19%. Comparing base (58bd325) to head (6e43eb0).

Files with missing lines Patch % Lines
press/agent.py 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2213      +/-   ##
==========================================
- Coverage   42.19%   42.19%   -0.01%     
==========================================
  Files         376      376              
  Lines       28695    28698       +3     
==========================================
+ Hits        12109    12110       +1     
- Misses      16586    16588       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant