Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Agent): Propagate non-job request exceptions to foreground #2382

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

balamurali27
Copy link
Contributor

@balamurali27 balamurali27 commented Dec 23, 2024

For requests that aren't jobs, it's easier to debug the cause if they
are propagated to frontend rather than logged.
TODO:

  • Throw actual error from agent into frontend rather than raise_for_status

Eg: Login as admin
ref: https://support.frappe.io/helpdesk/tickets/27474 was failing due to journeys app. Had to ssh and run the command to see what the issue was.
Another case: https://support.frappe.io/helpdesk/tickets/27477

For requests that aren't jobs, it's easier to debug the cause if they
are propagated to frontend rather than logged
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 38.58%. Comparing base (ed58508) to head (62beb44).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
press/agent.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2382   +/-   ##
=======================================
  Coverage   38.58%   38.58%           
=======================================
  Files         376      376           
  Lines       29080    29080           
=======================================
  Hits        11221    11221           
  Misses      17859    17859           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@balamurali27 balamurali27 marked this pull request as draft December 23, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant