Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Column resizing issue #164

Open
nilpatel42 opened this issue Jun 29, 2023 · 2 comments
Open

Column resizing issue #164

nilpatel42 opened this issue Jun 29, 2023 · 2 comments

Comments

@nilpatel42
Copy link

My code is already updated but after resizing the column when i save wiki page, its not changing
@nilpatel42
Copy link
Author

when i edit second time it will reset to it's real width, every time i need to change width column

@nilpatel42 nilpatel42 mentioned this issue Jul 1, 2023
Closed
@BreadGenie BreadGenie reopened this Jul 1, 2023
@BreadGenie
Copy link
Member

BreadGenie commented Jul 1, 2023 •
edited
Loading

There were 2 bugs that happened here.

  • Tiptap omitted <colgroup> and <col> tags that determines the width of table cell while using editor.getHTML() method. So I had to do a hack using jquery to fetch the HTML in editor (sub optimal fix until tiiptap fixes this issue)
  • Tiptap doesn't load the saved HTML properly (missing attributes in tables)

reference ueberdosis/tiptap#4105

BreadGenie added a commit that referenced this issue Jul 3, 2023
@BreadGenie
fix: colgroup size not being saved
989dbde 
fix #164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BreadGenie @nilpatel42