Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor bug in registerHTTPHandler() function #3

Open
mwittig opened this issue Jun 9, 2015 · 0 comments
Open

Minor bug in registerHTTPHandler() function #3

mwittig opened this issue Jun 9, 2015 · 0 comments

Comments

@mwittig
Copy link

mwittig commented Jun 9, 2015

I discovered a minor bug in registerHTTPHandler(). The case where url.pathname does not start with peer.prefix is not handled, i.e. no response is generated for this case. I noticed it when using "Get Device XML" as part of Intel UPnP Device Spy, which opens a web browser to show the device XML. As most web browsers try to load a favicon from the same site, this causes the browser to keep on loading as there is no response to the favicon GET request. I'll file a PR with a suggested fix.
mwittig added a commit to mwittig/peer-upnp that referenced this issue Jun 9, 2015
@mwittig
Suggested fix for issue fraunhoferfokus#3 - The case where url.pathna…
a7e7819 
…me does not start with peer.prefix is not handled, i.e. no response is generated for this case.
@mwittig mwittig mentioned this issue Jun 9, 2015
Open
mwittig added a commit to mwittig/peer-upnp that referenced this issue Jun 10, 2015
@mwittig
Revert "Suggested fix for issue fraunhoferfokus#3 - The case where ur…
f821f9c 
…l.pathname does not start with peer.prefix is not handled, i.e. no response is generated for this case."

This reverts commit a7e7819.
mwittig added a commit to mwittig/peer-upnp that referenced this issue Jun 10, 2015
@mwittig
Revert "Revert "Suggested fix for issue fraunhoferfokus#3 - The case …
3b535e3 
…where url.pathname does not start with peer.prefix is not handled, i.e. no response is generated for this case.""

This reverts commit f821f9c.
mwittig added a commit to mwittig/peer-upnp that referenced this issue Oct 1, 2015
@mwittig
Suggested fix for issue fraunhoferfokus#3 - The case where url.pathna…
6d2be3f 
…me does not start with peer.prefix is not handled, i.e. no response is generated for this case.
mwittig added a commit to mwittig/peer-upnp that referenced this issue Oct 1, 2015
@mwittig
Revert "Suggested fix for issue fraunhoferfokus#3 - The case where ur…
ede0cb1 
…l.pathname does not start with peer.prefix is not handled, i.e. no response is generated for this case."

This reverts commit a7e7819.
mwittig added a commit to mwittig/peer-upnp that referenced this issue Oct 1, 2015
@mwittig
Revert "Revert "Suggested fix for issue fraunhoferfokus#3 - The case …
f261fdd 
…where url.pathname does not start with peer.prefix is not handled, i.e. no response is generated for this case.""

This reverts commit f821f9c.
mwittig added a commit to mwittig/peer-upnp that referenced this issue Oct 1, 2015
@mwittig
Updated dependencies. Now using peer-ssdp fork with suggested fix for…
80cee6f 
… peer-ssdp issue fraunhoferfokus#3: addMembership EADDRNOTAVAIL revisited -
mwittig added a commit to mwittig/peer-upnp that referenced this issue Jan 12, 2018
@mwittig
Suggested fix for issue fraunhoferfokus#3 - The case where url.pathna…
3cb16ef 
…me does not start with peer.prefix is not handled, i.e. no response is generated for this case.
mwittig added a commit to mwittig/peer-upnp that referenced this issue Jan 12, 2018
@mwittig
Revert "Suggested fix for issue fraunhoferfokus#3 - The case where ur…
695e950 
…l.pathname does not start with peer.prefix is not handled, i.e. no response is generated for this case."

This reverts commit a7e7819.
mwittig added a commit to mwittig/peer-upnp that referenced this issue Jan 12, 2018
@mwittig
Revert "Revert "Suggested fix for issue fraunhoferfokus#3 - The case …
1cbac1e 
…where url.pathname does not start with peer.prefix is not handled, i.e. no response is generated for this case.""

This reverts commit f821f9c.
mwittig added a commit to mwittig/peer-upnp that referenced this issue Jan 12, 2018
@mwittig
Updated dependencies. Now using peer-ssdp fork with suggested fix for…
398ef8a 
… peer-ssdp issue fraunhoferfokus#3: addMembership EADDRNOTAVAIL revisited -
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mwittig