handleSubscribeEvent checks for renew and fails if not already subscribed #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lready subscribed
rtyle
changed the title
|
Thank you for letting me stand on your shoulders. The peer-upnp product is an essential dependency of upnp-things. As that exists, it depends on this fix. I would like to publish upnp-things as a complete npm package but I would like for it to depend on a fixed peer-upnp. I would be grateful for you to accept this fix here and update your npm package. Thank you. |
|
@rtyle I added one comment please check it |
Please forgive my ignorance. Where/how do I check it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.