This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
Add changes that were tested on the robot #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Work from programming 11/10/2020 session Includes updated code for control-panel and everything co-authors were doing as well. Co-Authored-By: Andrew Lester <23221268+AndrewLester@users.noreply.github.com> Co-Authored-By: BobbyMi11er <45018886+BobbyMi11er@users.noreply.github.com> Co-Authored-By: Joe Carpenter <32715516+JosephCarpenter@users.noreply.github.com> Co-Authored-By: beaster4435 <56608638+beaster4435@users.noreply.github.com>
Co-Authored-By: Simkz <23221325+Simkz@users.noreply.github.com> Co-Authored-By: BobbyMi11er <45018886+BobbyMi11er@users.noreply.github.com> Co-Authored-By: Joe Carpenter <32715516+JosephCarpenter@users.noreply.github.com> Co-Authored-By: BrandonWerbel <56608573+BrandonWerbel@users.noreply.github.com> Co-Authored-By: Tim Winters <twinters@wpi.edu>
This was
linked to
issues
Nov 24, 2020
Closed
ErikBoesen
suggested changes
Nov 24, 2020
CTRESim-java/src/main/java/com/ctre/phoenix/motorcontrol/can/WPI_VictorSPX.java
Show resolved
Hide resolved
AndrewLester
requested review from
donovanj44,
BobbyMi11er,
BrandonWerbel,
JosephCarpenter,
quirozj and
TurtleDan
ErikBoesen
approved these changes
Dec 2, 2020
| } | ||
|
|
||
| public static ControlPanelColor getColorFromCode(String colorKey) { | ||
| if (colorKey.equals("R")) { |
There was a problem hiding this comment.
You may wish to use a hash map or similar data structure to make this logic simpler.
ArchdukeTim
reviewed
Dec 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.