Skip to content
This repository has been archived by the owner on Aug 1, 2020. It is now read-only.

Remove Nested Navigation State from LocalStorage #78

Closed
Maybach91 opened this issue Jan 21, 2019 · 1 comment · Fixed by #110
Closed

Remove Nested Navigation State from LocalStorage #78

Maybach91 opened this issue Jan 21, 2019 · 1 comment · Fixed by #110
Assignees
@LeBenLeBen
Labels
[area] behavior feature-request

Comments

@Maybach91
Copy link

Currently all the opened/closed nested Navigation states are save in LocalStorage. I think this behaviour is pretty uncommon and annoying. I can not imagine one single usecase, in which this would be helpful.

The Quick'n'Dirty fix is currently to overwrite the storage.js file within my own theme folder.
@Chapabu Chapabu changed the title Feature Request: Remove Nested Navigation State from LocalStorage Remove Nested Navigation State from LocalStorage Jan 21, 2019
@LeBenLeBen
Copy link
Member

I think it can be useful when you're refreshing a page, but for that specific purpose we could move to SessionStorage so it's not restored when you come back later.

Also the addition of a button that allows you to toggle all navigation items could help improve the experience.

@LeBenLeBen LeBenLeBen mentioned this issue Feb 15, 2019
Closed
@LeBenLeBen LeBenLeBen self-assigned this Apr 29, 2020
LeBenLeBen added a commit that referenced this issue May 2, 2020
@LeBenLeBen
feat: persist navigation state only for the current session
55aa579 
Fixes #78
@LeBenLeBen LeBenLeBen mentioned this issue May 2, 2020
Merged
@LeBenLeBen LeBenLeBen linked a pull request May 2, 2020 that will close this issue
feat: persist navigation state only for the current session #110
Merged
LeBenLeBen added a commit that referenced this issue May 9, 2020
@LeBenLeBen
feat: persist navigation state only for the current session
34dd1ac 
Fixes #78
LeBenLeBen added a commit that referenced this issue May 15, 2020
@LeBenLeBen
feat: persist navigation state only for the current session
14108f4 
Fixes #78
mihkeleidast pushed a commit that referenced this issue May 15, 2020
@LeBenLeBen
feat: persist navigation state only for the current session (#110)
f993983 
Fixes #78
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@LeBenLeBen LeBenLeBen

Labels
[area] behavior feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: persist navigation state only for the current session frctl/mandelbrot
4 participants
@LeBenLeBen @Chapabu @Maybach91 @mihkeleidast