Skip to content
This repository has been archived by the owner on Jul 22, 2020. It is now read-only.

add support for docs #37

Merged
merged 1 commit into from
Jan 2, 2020
Merged

add support for docs #37

merged 1 commit into from
Jan 2, 2020

Conversation

mihkeleidast
Copy link
Member

This PR will:

Background for the documentation weirdness:
If the engines are set in the opposite order (for components first, then for docs), then due to the fact how the adapter currently extends & monkeypatches Twig, all includes will try to reference docs entities instead of component entities.

I think we should try to find a way to improve that, since the order of setting engines in the config should not make a difference.

Manually tested that, when following the docs:

  • including components via handles still works
  • including components via full path (with the usage of base config option, i don't believe regular relative paths have ever worked)
  • render tag will continue to work

@Chapabu Chapabu merged commit ad773b7 into frctl:master Jan 2, 2020
@mihkeleidast mihkeleidast deleted the fix-19 branch January 3, 2020 16:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not work for documentation entities
2 participants