This repository has been archived by the owner on Jul 22, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will:
@frctl/handlebars
)Background for the documentation weirdness:
If the engines are set in the opposite order (for components first, then for docs), then due to the fact how the adapter currently extends & monkeypatches Twig, all includes will try to reference docs entities instead of component entities.
I think we should try to find a way to improve that, since the order of setting engines in the config should not make a difference.
Manually tested that, when following the docs:
base
config option, i don't believe regular relative paths have ever worked)render
tag will continue to work