Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer slice for copying arrays #14

Open
freaktechnik opened this issue Feb 15, 2018 · 2 comments
Open

Prefer slice for copying arrays #14

freaktechnik opened this issue Feb 15, 2018 · 2 comments

Comments

@freaktechnik
Copy link
Owner

Array.from etc. are probably slower. Need to investigate.

@freaktechnik
Copy link
Owner Author

Made a little test case for peace of mind: https://jsperf.com/array-cloning-freak/1

The ranking is as follows (checked in Chromium and Firefox, so we have V8 and SpiderMonkey):

  1. Array.prototype.slice
  2. Reflect.construct(Array
  3. Array.prototype.map (performs better than Reflect.construct in SpiderMonkey)
  4. Everything else, like spreading or Array.from... (far slower)

@freaktechnik
Copy link
Owner Author

This should actually be a rule where the user can choose their preferred method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant