Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add GHC 9.6.5 #21

Merged
merged 2 commits into from
May 7, 2024
Merged

chore: Add GHC 9.6.5 #21

merged 2 commits into from
May 7, 2024

Conversation

OlaoluwaM
Copy link
Contributor

@OlaoluwaM OlaoluwaM commented May 6, 2024

Due to some segfault issues when running make build in text-assets, I had to bump up the text-assets GHC version to 9.6.5 (LTS 22.21). This PR adds support for GHC 9.6.5 to the weeder GitHub action

The issues in question were often:

make: *** [build] Bus error: 10

and less often:

text-assets: internal error: ARR_WORDS object (0x16e4f2e40) entered!
    (GHC version 9.6.3 for aarch64_apple_darwin)
    Please report this as a GHC bug:  https://www.haskell.org/ghc/reportabug
make: *** [build] Abort trap: 6

@OlaoluwaM OlaoluwaM requested review from pbrisbin and chris-martin May 6, 2024 20:28
@OlaoluwaM OlaoluwaM self-assigned this May 6, 2024
Copy link
Member

@pbrisbin pbrisbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you drew the short straw, and will have to fix the macOS builds for the new runners lacking a stack install. Let me know if you need more context or support.

@OlaoluwaM
Copy link
Contributor Author

So it looks like Haskell development tools (ie stack) were purposefully removed to streamline macos images: actions/runner-images#9242 @pbrisbin. Sounds like we'll need to install it ourselves. How do I go about doing that?

@pbrisbin
Copy link
Member

pbrisbin commented May 6, 2024

Yeah, it's a shame that URL is the link everyone finds and it doesn't include the fix. I just commented there with the snippet I've been using.

@OlaoluwaM OlaoluwaM requested a review from pbrisbin May 6, 2024 21:17
Copy link
Contributor

@chris-martin chris-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the checks are happy, so am I

@OlaoluwaM OlaoluwaM merged commit d871489 into main May 7, 2024
6 checks passed
@OlaoluwaM OlaoluwaM deleted the ola/add-new-ghc-version branch May 7, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants