Update conditions around unused functions #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackptr
approved these changes
Jun 11, 2024
This is behavior neutral, but it corrects that fact that we output "unused functions found" for any error, regardless of the version of weeder (i.e. even when we can trust its exit code to know). Now this should output "unused functions found" or "some other error" correctly. We did the code the way it was originally to minimize diff when introducing the logic based on weeder version, which required larger changes elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is behavior neutral, but it corrects that fact that we output
"unused functions found" for any error, regardless of the version of
weeder (i.e. even when we can trust its exit code to know). Now this
should output "unused functions found" or "some other error" correctly.
We did the code the way it was originally to minimize diff when
introducing the logic based on weeder version, which required larger
changes elsewhere.